Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2299543003: Remove old clear browsing data methods on iOS (Closed)

Created:
4 years, 3 months ago by ioanap
Modified:
4 years, 3 months ago
Reviewers:
droger
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, sdefresne+watch_chromium.org, msramek, melandory
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old clear browsing data methods on iOS The new methods now take a browsing_data::TimePeriod as a parameter to permit time-scoped deletion. BUG=642334 Committed: https://crrev.com/517de915f141a3d69c685bbfe5716af7b8306f12 Cr-Commit-Position: refs/heads/master@{#420029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M ios/chrome/browser/browsing_data/browsing_data_remover_helper.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/browsing_data/browsing_data_remover_helper.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/commands/clear_browsing_data_command.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/commands/clear_browsing_data_command.mm View 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (14 generated)
ioanap
Please take a look! Thanks, Ioana
4 years, 3 months ago (2016-09-19 14:50:48 UTC) #8
ioanap
On 2016/09/19 14:50:48, ioanap wrote: > Please take a look! > > Thanks, > Ioana ...
4 years, 3 months ago (2016-09-19 14:52:37 UTC) #9
droger
lgtm
4 years, 3 months ago (2016-09-19 14:59:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299543003/1
4 years, 3 months ago (2016-09-21 12:13:35 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 12:18:39 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 12:21:09 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/517de915f141a3d69c685bbfe5716af7b8306f12
Cr-Commit-Position: refs/heads/master@{#420029}

Powered by Google App Engine
This is Rietveld 408576698