Add an ability for resize in gallery.

ui/file_manager/gallery/js/image_editor/image_editor.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * ImageEditor is the top level object that holds together and connects
  * everything needed for image editing.
  *
  * @param {!Viewport} viewport The viewport.
  * @param {!ImageView} imageView The ImageView containing the images to edit.
@@ skipping 26 matching lines @@
   /**
    * @private {HTMLElement}
    */
   this.currentTool_ = null;
 
   /**
    * @private {boolean}
    */
   this.settingUpNextMode_ = false;
 
+  /**
+   * @private {boolean}
+   */
+  this.showingAlertDialog_ = false;
+
   ImageUtil.removeChildren(this.container_);
 
   this.viewport_ = viewport;
 
   this.imageView_ = imageView;
 
   this.buffer_ = new ImageBuffer();
   this.buffer_.addOverlay(this.imageView_);
 
   this.panControl_ = new ImageEditor.MouseControl(
@@ skipping 615 matching lines @@
 /**
  * The user clicked on 'OK' or 'Cancel' or on a different mode button.
  * @param {boolean} commit True if commit is required.
  * @param {boolean} leaveToSwitchMode True if it leaves to change mode.
  * @private
  */
 ImageEditor.prototype.leaveModeInternal_ = function(commit, leaveToSwitchMode) {
   if (!this.currentMode_)
     return;
 
+  // If the current mode is image-resize, and commit is required,
+  // leaving mode should be stopped when an input value is not valid.
+  if(commit && this.currentMode_.name === 'image-resize') {

[fukino, 2016/09/05 13:44:34]

I think this 'image-resize' should be 'resize'?
The dialog won't be shown on the latest code.

[harukam, 2016/09/06 08:10:29]

Sorry, thanks.

+    var resizeMode = /** @type {!ImageEditor.Mode.Resize} */
+                              (this.currentMode_);
+    if(!resizeMode.isInputValid()) {
+      this.showingAlertDialog_ = true;
+
+      resizeMode.showAlertDialog(function() {
+        this.showingAlertDialog_ = false;
+      }.bind(this));
+      return;
+    }
+  }
+
   this.modeToolbar_.show(false);
 
   // If it leaves to switch mode, do not restore screen size since the next mode
   // might change screen size. We should avoid to show intermediate animation
   // which tries to restore screen size.
   if (!leaveToSwitchMode) {
     this.getViewport().setScreenTop(ImageEditor.Toolbar.HEIGHT);
     this.getViewport().setScreenBottom(ImageEditor.Toolbar.HEIGHT);
     this.getImageView().applyViewportChange();
   }
@@ skipping 52 matching lines @@
 
 /**
  * Key down handler.
  * @param {!Event} event The keydown event.
  * @return {boolean} True if handled.
  */
 ImageEditor.prototype.onKeyDown = function(event) {
   switch (util.getKeyModifiers(event) + event.key) {
     case 'Escape':
     case 'Enter':
+      if (this.showingAlertDialog_)
+        return false;
       if (this.getMode()) {
         this.leaveModeInternal_(event.key === 'Enter',
             false /* not to switch mode */);
         return true;
       }
       break;
 
     case 'Ctrl-z':  // Ctrl+Z
       if (this.commandQueue_.canUndo()) {
         this.undo();
@@ skipping 527 matching lines @@
  */
 ImageEditor.Toolbar.prototype.addButton = function(
     title, type, handler, opt_class) {
   var button = ImageEditor.Toolbar.createButton_(
       title, type, handler, opt_class);
   this.add(button);
   return button;
 };
 
 /**
+ * Add a checkbox
+ *
+ * @param {string} name Checkbox name
+ * @param {string} title Checkbox title
+ * @param {function(Event)} handler onChange handler
+ * @param {boolean} value Default value
+ * @return {!HTMLElement} Checkbox Element
+ */
+ImageEditor.Toolbar.prototype.addCheckbox = function(
+    name, title, handler, value) {
+
+  var checkbox = /** @type {!HTMLElement} */
+      (document.createElement('paper-checkbox'));
+  checkbox.textContent = strf(title);
+  checkbox.addEventListener('change', handler, false);
+  checkbox.checked = value;
+  checkbox.classList.add('checkbox', name);
+
+  this.add(checkbox);
+
+  return checkbox;
+};
+
+/**
+ * Add a input field.
+ *
+ * @param {string} name Input name
+ * @param {string} title Input title
+ * @param {function(Event)} handler onInput and onChange handler
+ * @param {string|number} value Default value
+ * @param {string=} opt_unit Unit for an input field
+ * @return {!HTMLElement} Input Element
+ */
+ImageEditor.Toolbar.prototype.addInput = function(
+    name, title, handler, value, opt_unit) {
+
+  var input = /** @type {!HTMLElement} */ (document.createElement('div'));
+  input.classList.add('input', name);
+
+  var text = document.createElement('paper-input');
+  text.setAttribute('label', strf(title));
+  text.classList.add('text', name);
+  text.value = value;
+
+  // We should listen for not only 'change' event, but also 'input' because of

[fukino, 2016/09/05 13:44:34]

listen to

[harukam, 2016/09/06 08:10:29]

Acknowledged.

+  // calling handler as fast as possible.

[fukino, 2016/09/05 13:44:34]

"because of calling..." doesn't sound saying purpose.

How about "because we want to update values as soon as the user types
characters." or something like that?

[harukam, 2016/09/06 08:10:29]

It's helpful, thanks.

+  text.addEventListener('input', handler, false);
+  text.addEventListener('change', handler, false);

[harukam, 2016/09/05 10:37:00]

I set a handler listening for 'change' event to adjust
test.util.sync.changeValue in gallery/js/test_util.js.

+  input.appendChild(text);
+
+  if(opt_unit) {
+    var unit_label = document.createElement('span');
+    unit_label.textContent = opt_unit;
+    unit_label.classList.add('unit_label');
+    input.appendChild(unit_label);
+  }
+
+  input.name = name;
+  input.getValue = function(text) {
+    return text.value;
+  }.bind(this, text);
+  input.setValue = function(text, value) {
+    text.value = value;
+  }.bind(this, text);
+
+  this.add(input);
+
+  return input;
+};
+
+/**
  * Add a range control (scalar value picker).
  *
  * @param {string} name An option name.
  * @param {string} title An option title.
  * @param {number} min Min value of the option.
  * @param {number} value Default value of the option.
  * @param {number} max Max value of the options.
  * @param {number=} opt_scale A number to multiply by when setting
  *     min/value/max in DOM.
  * @param {boolean=} opt_showNumeric True if numeric value should be displayed.
@@ skipping 217 matching lines @@
 
 /**
  * Hide the prompt.
  */
 ImageEditor.Prompt.prototype.hide = function() {
   if (!this.prompt_) return;
   this.prompt_.setAttribute('state', 'fadeout');
   // Allow some time for the animation to play out.
   this.setTimer(this.reset.bind(this), 500);
 };