blimp/client/public/blimp_client_context.h - Issue 2299453002: Restrict number of BlimpContents to [0, 1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/blimp_client_context.h

Issue 2299453002: Restrict number of BlimpContents to [0, 1] (Closed)

Patch Set: patch failure fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/public/blimp_client_context.h

diff --git a/blimp/client/public/blimp_client_context.h b/blimp/client/public/blimp_client_context.h

index 52573d3a726e438e4bc4b0ffa1083320b5237447..98999dd72781ba16423074d87060c88d41ef86dc 100644

--- a/blimp/client/public/blimp_client_context.h

+++ b/blimp/client/public/blimp_client_context.h

@@ -52,6 +52,8 @@ class BlimpClientContext : public KeyedService {

virtual void SetDelegate(BlimpClientContextDelegate* delegate) = 0;

// Creates a new BlimpContents.

+ // TODO(mlliu): Currently we want to have a single BlimpContents. If there is

+ // an existing contents, return nullptr (http://crbug.com/642558).

virtual std::unique_ptr<BlimpContents> CreateBlimpContents() = 0;

// Start authentication flow and connection to engine.