Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/client/public/blimp_client_context.h

Issue 2299453002: Restrict number of BlimpContents to [0, 1] (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/client/core/contents/blimp_contents_manager_unittest.cc ('K') | « blimp/client/core/contents/blimp_contents_manager_unittest.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/public/blimp_client_context.h
diff --git a/blimp/client/public/blimp_client_context.h b/blimp/client/public/blimp_client_context.h
index 52573d3a726e438e4bc4b0ffa1083320b5237447..1ffbe93b1b92779c4e07446b0e2b3a53ad00f4b7 100644
--- a/blimp/client/public/blimp_client_context.h
+++ b/blimp/client/public/blimp_client_context.h
@@ -52,6 +52,8 @@ class BlimpClientContext : public KeyedService {
virtual void SetDelegate(BlimpClientContextDelegate* delegate) = 0;
// Creates a new BlimpContents.
+ // Currently we want to have a single BlimpContents. If there is an existing
David Trainor- moved to gerrit 2016/08/30 23:31:12 Add the same TODO.
Menglin 2016/08/31 00:13:02 Done.
+ // contents, return nullptr.
virtual std::unique_ptr<BlimpContents> CreateBlimpContents() = 0;
// Start authentication flow and connection to engine.
« blimp/client/core/contents/blimp_contents_manager_unittest.cc ('K') | « blimp/client/core/contents/blimp_contents_manager_unittest.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698