Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2299443002: Update MenuButton closing time for async (Closed)

Created:
4 years, 3 months ago by jonross
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update MenuButton closing time for async MenuButton rejects openning new menus when a reposted event arrives too close to the closing time of the menu. However this calculation was based on menus always being synchronous. Updating MenuButton to set the closed time based on the pressed state being decremented to 0. This works for both synchronous and async menus. TEST=manual testing of translate bubble, and other menu buttons, views_unittests BUG=642254 Committed: https://crrev.com/df1837b274e20b9ce31a03acd625bdd1775d71c7 Cr-Commit-Position: refs/heads/master@{#415636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/views/controls/button/menu_button.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hey, As you thought offline, MenuButton's pre-existing decrement method handles the issue perfectly fine. Could ...
4 years, 3 months ago (2016-08-30 22:26:42 UTC) #2
sky
Nice. I like easy. LGTM
4 years, 3 months ago (2016-08-30 22:40:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299443002/1
4 years, 3 months ago (2016-08-31 13:18:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 15:18:08 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 15:19:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df1837b274e20b9ce31a03acd625bdd1775d71c7
Cr-Commit-Position: refs/heads/master@{#415636}

Powered by Google App Engine
This is Rietveld 408576698