Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2299423002: [Material][Mac] Replace hard-coded default favicon with .icon file (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Replace hard-coded default favicon with .icon file BUG=619627 Committed: https://crrev.com/63d027126b56e97d2d1d8f955af5d65547a11eb1 Cr-Commit-Position: refs/heads/master@{#416385}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Vector icon file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -71 lines) Patch
M chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm View 3 chunks +7 lines, -71 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/vector_icons/default_favicon.icon View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
spqchan
PTAL
4 years, 3 months ago (2016-09-01 23:39:45 UTC) #2
Avi (use Gerrit)
LGTM
4 years, 3 months ago (2016-09-02 00:18:22 UTC) #3
spqchan
On 2016/09/02 00:18:22, Avi wrote: > LGTM thanks!
4 years, 3 months ago (2016-09-02 00:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299423002/1
4 years, 3 months ago (2016-09-02 00:20:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/218111)
4 years, 3 months ago (2016-09-02 00:38:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299423002/40001
4 years, 3 months ago (2016-09-02 21:21:37 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 23:29:33 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:31:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/63d027126b56e97d2d1d8f955af5d65547a11eb1
Cr-Commit-Position: refs/heads/master@{#416385}

Powered by Google App Engine
This is Rietveld 408576698