Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2299383002: Add a specific switch to force enable blimp. (Closed)

Created:
4 years, 3 months ago by David Trainor- moved to gerrit
Modified:
4 years, 3 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a specific switch to force enable blimp. Add a BLIMP_ENABLED switch. BUG=640736 Committed: https://crrev.com/03369ca21a7a5739d5a2934644833e97cac2fcb3 Cr-Commit-Position: refs/heads/master@{#416314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
David Trainor- moved to gerrit
ptal thanks!
4 years, 3 months ago (2016-09-01 21:48:17 UTC) #2
Khushal
lgtm Awesome!
4 years, 3 months ago (2016-09-02 17:43:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299383002/1
4 years, 3 months ago (2016-09-02 18:22:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 19:08:55 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 19:10:54 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/03369ca21a7a5739d5a2934644833e97cac2fcb3
Cr-Commit-Position: refs/heads/master@{#416314}

Powered by Google App Engine
This is Rietveld 408576698