Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2299333003: Revert of Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl." (Closed)

Created:
4 years, 3 months ago by Khushal
Modified:
4 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 … (patchset #2 id:20001 of https://codereview.chromium.org/2297273004/ ) Reason for revert: The test is still failing. Original issue's description: > Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )" > > This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03. > > TBR = dtrainor > BUG=643199, 643282 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3 > Cr-Commit-Position: refs/heads/master@{#416062} TBR=piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643199, 643282 Committed: https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138 Cr-Commit-Position: refs/heads/master@{#416154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -293 lines) Patch
M content/browser/browser_main_loop.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 4 chunks +0 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 7 chunks +0 lines, -18 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +19 lines, -39 lines 0 comments Download
M content/browser/renderer_host/context_provider_factory_impl_android.h View 5 chunks +12 lines, -19 lines 0 comments Download
M content/browser/renderer_host/context_provider_factory_impl_android.cc View 7 chunks +57 lines, -88 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +0 lines, -7 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 3 chunks +0 lines, -5 lines 0 comments Download
D content/test/mock_gpu_channel_establish_factory.h View 1 chunk +0 lines, -26 lines 0 comments Download
D content/test/mock_gpu_channel_establish_factory.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M content/test/test_render_view_host.cc View 3 chunks +7 lines, -20 lines 0 comments Download
M ui/android/context_provider_factory.h View 2 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Khushal
Created Revert of Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 ...
4 years, 3 months ago (2016-09-02 01:21:47 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138 Cr-Commit-Position: refs/heads/master@{#416154}
4 years, 3 months ago (2016-09-02 01:25:47 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 01:25:49 UTC) #7
Message was sent while issue was closed.
CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Powered by Google App Engine
This is Rietveld 408576698