Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2299303002: Fix PostUploadHook for Gerrit issues (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix PostUploadHook for Gerrit issues A gerrit change must contain the "Change-Id" at the end. This CL strips out the changeId from the description and adds it back in at the end. BUG=skia:5676 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299303002 NOTRY=true Committed: https://skia.googlesource.com/skia/+/07f0446e9a36e39814a92a1681ab59de79275651

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
rmistry
4 years, 3 months ago (2016-09-01 20:12:00 UTC) #3
jcgregorio
lgtm
4 years, 3 months ago (2016-09-01 20:21:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299303002/20001
4 years, 3 months ago (2016-09-01 20:35:32 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:36:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/07f0446e9a36e39814a92a1681ab59de79275651

Powered by Google App Engine
This is Rietveld 408576698