Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2299243002: Revert "Remove unnecessary hide clauses" (Closed)

Created:
4 years, 3 months ago by Paul Berry
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove unnecessary hide clauses" The `Resource` class wasn't removed from the SDK until version 1.20.0-dev.0.0, which was only recently published. Reverting this change to allow people using older SDK releases a little more time to upgrade. This reverts commit 2cdafd82c2c2c18dd505a5e3d3a17c9efb0fb4a1. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/94309733cdff20f9af3e563035bb2989cf8d6b69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/watch_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/sdk_ext.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/bazel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/incremental_cache.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/pub_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/embedder_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 3 months ago (2016-09-01 17:50:49 UTC) #2
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-01 18:01:07 UTC) #3
scheglov
LGTM
4 years, 3 months ago (2016-09-01 18:07:30 UTC) #4
Paul Berry
4 years, 3 months ago (2016-09-01 23:08:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
94309733cdff20f9af3e563035bb2989cf8d6b69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698