third_party/WebKit/LayoutTests/fast/text-autosizing/js-change-short-text-to-long.html - Issue 2299213003: Fix the inconsistent problem while the content of textNodes is changed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/text-autosizing/js-change-short-text-to-long.html

Issue 2299213003: Fix the inconsistent problem while the content of textNodes is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 1. change 'FingerPrint' to 'Fingerprint' 2. remove const from BlockSet 3. change 'textAutosizingNew… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/text-autosizing/js-change-short-text-to-long-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutText.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <meta name="viewport" content="width=800">

	4 <style>

	5 html { font-size: 16px; }

	6 body { width: 800px; margin: 0; overflow-y: hidden; }

	7 </style>

	8 <script src="resources/autosizingTest.js"></script>

	9 </head>

	10 <body>

	11 <table width="760">

	12 <tr>

	13 <td colspan="2">

	14 <table width="760" style="table-layout:fixed;word-wrap:break-wor d;">

	15 <tr>

	16 <td class="read">

	17 <div id="longText">short blah blah</div>

	18 </td>

	19 </tr>

	20 </table>

	21 </td>

	22 </tr>

	23

	24 <tr>

	25 <td colspan="2">

	26 <table width="760" style="table-layout:fixed;word-wrap:break-wor d;">

	27 <tr>

	28 <td class="read">

	29 <div id="shortText">short blah blah</div>

	30 </td>

	31 </tr>

	32 </table>

	33 </td>

	34 </tr>

	35 </table>

	36

	37 <script>

	38 function changeText() {

	39 document.getElementById("longText").innerHTML="l ong blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah b lah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah b lah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah b lah blah blah blah blah blah blah";

	40 }

	41

	42 function testConsistent() {

	43 var longText = document.getElementById('longText');

	44 var longTextComputedFontSize = parseInt(window.getComputedSt yle(longText).fontSize);

	45

	46 var shortText = document.getElementById('shortText');

	47 var shortTextComputedFontSize = parseInt(window.getComputedS tyle(shortText).fontSize);

	48

	49 if (longTextComputedFontSize == shortTextComputedFontSize)

	50 document.write('PASS');

	51 else

	52 document.write('FAIL. Expected longTextComputedFontSize == shortTextComputedFontSize.\n ' + longTextComputedFontSize + ': ' + shortTextCom putedFontSize);

	53

	54 if (window.testRunner)

	55 testRunner.dumpAsText();

	56 }

	57

	58 setTimeout("changeText()", 100);
	pdr. 2016/11/10 06:04:09 When the text autosizer was first written, we only When the text autosizer was first written, we only had primitive layouttest technology. For new code, prefer unit tests because they are much faster to run on the bots. Do you mind rewriting these tests in TextAutosizerTest.cpp? I think you can use a similar pattern to the DeviceScaleAdjustmentWithViewport test. cathiechentx 2016/11/11 09:34:12 Good to know! Will do... Show quoted text On 2016/11/10 06:04:09, pdr. wrote: > When the text autosizer was first written, we only had primitive layouttest > technology. For new code, prefer unit tests because they are much faster to run > on the bots. Do you mind rewriting these tests in TextAutosizerTest.cpp? I think > you can use a similar pattern to the DeviceScaleAdjustmentWithViewport test. Good to know! Will do...
	59 setTimeout("testConsistent()", 200);

	60 </script>

	61 </body>

	62 </html>

OLD	NEW