Attempt to repair corrupt enterprise policy force-installed extensions

extensions/browser/updater/extension_downloader.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_UPDATER_EXTENSION_DOWNLOADER_H_
 #define EXTENSIONS_BROWSER_UPDATER_EXTENSION_DOWNLOADER_H_
 
 #include <deque>
 #include <map>
 #include <memory>
@@ skipping 62 matching lines @@
   // The |request_id| is passed on as is to the various |delegate_| callbacks.
   // This is used for example by ExtensionUpdater to keep track of when
   // potentially concurrent update checks complete.
   bool AddExtension(const Extension& extension, int request_id);
 
   // Adds extension |id| to the list of extensions to check for updates.
   // Returns false if the |id| can't be updated due to invalid details.
   // In that case, no callbacks will be performed on the |delegate_|.
   // The |request_id| is passed on as is to the various |delegate_| callbacks.
   // This is used for example by ExtensionUpdater to keep track of when
   // potentially concurrent update checks complete.

[lazyboy, 2016/09/02 19:21:53]

Update comment about |is_corrupt_reinstall|

[asargent_no_longer_on_chrome, 2016/09/09 03:30:44]

Done.

   bool AddPendingExtension(const std::string& id,
                            const GURL& update_url,
+                           bool is_corrupt_reinstall,
                            int request_id);
 
   // Schedules a fetch of the manifest of all the extensions added with
   // AddExtension() and AddPendingExtension().
   void StartAllPending(ExtensionCache* cache);
 
   // Schedules an update check of the blacklist.
   void StartBlacklistUpdate(const std::string& version,
                             const ManifestFetchData::PingData& ping_data,
                             int request_id);
@@ skipping 79 matching lines @@
     // Counts the number of times OAuth2 authentication has been attempted for
     // this fetch.
     int oauth2_attempt_count;
   };
 
   // Helper for AddExtension() and AddPendingExtension().
   bool AddExtensionData(const std::string& id,
                         const base::Version& version,
                         Manifest::Type extension_type,
                         const GURL& extension_update_url,
-                        const std::string& update_url_data,
+                        const ManifestFetchData::ExtraParams* extra,

[lazyboy, 2016/09/02 19:21:53]

Prefer ManifestFetchData::ExtraParams const ref to pointer. I see tests are
passing null, but that could simply become default ctor ExtraParams()

[asargent_no_longer_on_chrome, 2016/09/09 03:30:44]

Done.

                         int request_id);
 
   // Adds all recorded stats taken so far to histogram counts.
   void ReportStats() const;
 
   // Begins an update check.
   void StartUpdateCheck(std::unique_ptr<ManifestFetchData> fetch_data);
 
   // Called by RequestQueue when a new manifest fetch request is started.
   void CreateManifestFetcher();
@@ skipping 131 matching lines @@
 
   // Used to create WeakPtrs to |this|.
   base::WeakPtrFactory<ExtensionDownloader> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionDownloader);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_UPDATER_EXTENSION_DOWNLOADER_H_