Attempt to repair corrupt enterprise policy force-installed extensions

chrome/browser/chromeos/extensions/external_cache.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/external_cache.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 226 matching lines @@
   cached_extensions_->Clear();
   for (base::DictionaryValue::Iterator it(*extensions_.get());
        !it.IsAtEnd(); it.Advance()) {
     const base::DictionaryValue* entry = NULL;
     if (!it.value().GetAsDictionary(&entry)) {
       LOG(ERROR) << "ExternalCache found bad entry with type "
                  << it.value().GetType();
       continue;
     }
 
     bool keep_if_present =

[lazyboy, 2016/09/02 19:21:52]

unrelated to this CL, but generally I'd have expected this code to be in the
following form:
bool value = false;
bool keep_if_present = entry->Get(kKeepIfPresent, &value) && value;
i.e. my q is are we guaranteed to never set this value to false?

[asargent_no_longer_on_chrome, 2016/09/09 03:30:43]

I guess it just means that "keep_if_present" is a special key that connotes a
behavior just by its presence in the dictionary regardless of its value (of true
or false). If the dictionary doesn't have this key, then keep_if_present will be
false. 

         entry->HasKey(extensions::ExternalProviderImpl::kKeepIfPresent);
     std::string external_update_url;
     entry->GetString(extensions::ExternalProviderImpl::kExternalUpdateUrl,
                      &external_update_url);
     if (downloader_ && !keep_if_present) {
       GURL update_url;
       if (!external_update_url.empty())
         update_url = GURL(external_update_url);
       else if (always_check_updates_)
         update_url = extension_urls::GetWebstoreUpdateUrl();
 
       if (update_url.is_valid())
-        downloader_->AddPendingExtension(it.key(), update_url, 0);
+        downloader_->AddPendingExtension(it.key(), update_url, false, 0);
     }
 
     base::FilePath file_path;
     std::string version;
     std::string hash;
     if (local_cache_.GetExtension(it.key(), hash, &file_path, &version)) {
       // Copy entry to don't modify it inside extensions_.
       base::DictionaryValue* entry_copy = entry->DeepCopy();
 
       if (extension_urls::IsWebstoreUpdateUrl(GURL(external_update_url))) {
@@ skipping 87 matching lines @@
   OnPutExtension(id, file_path, file_ownership_passed);
   callback.Run(id, !file_ownership_passed);
 }
 
 std::string ExternalCache::Delegate::GetInstalledExtensionVersion(
     const std::string& id) {
   return std::string();
 }
 
 }  // namespace chromeos