Service account setup for headless Linux hosts

Service account setup for headless Linux hosts

BUG=224742
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218106

[rmsousa, 2013-08-13 01:24:43]

This change just adds the service account flow in the middle of the registration
flow.

It works, but it bugs me a bit that we need to get an oauth code for user
credentials, go through one oauth flow, use those credentials only once to
register the host, then go through another oauth flow to set up the host config
with the service account. I'll open a separate bug for rethinking our
registration flow.

[Sergey Ulanov, 2013-08-13 23:33:38]

https://codereview.chromium.org/22992002/diff/1/remoting/host/host_main.cc
File remoting/host/host_main.cc (right):

https://codereview.chromium.org/22992002/diff/1/remoting/host/host_main.cc#ne...
remoting/host/host_main.cc:237: if (!args.empty()) {
I think you fixed this in a separate CL.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
File remoting/host/setup/host_starter.cc (right):

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:105: if (host_id_.empty()) {
Add a comment that this function is used for both user account and robot
account.

Maybe check that host_owner_ is not empty here instead of looking at host_id_,
just to make this more readable?

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:107: xmpp_login_ = user_email;
I think it's better to set host_owner_ here and copy it to xmpp_login_ if we
don't get auth code for the robot account.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:137: } else {
add return in the case above and remove else. The no-robot-account case above
will be removed eventually.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:156: if (!host_owner_.empty()) {
Can we always set host_owner, even when using user credentials for the host (in
that case host_owner = xmpp_login)?

[rmsousa, 2013-08-14 02:13:12]

https://codereview.chromium.org/22992002/diff/1/remoting/host/host_main.cc
File remoting/host/host_main.cc (right):

https://codereview.chromium.org/22992002/diff/1/remoting/host/host_main.cc#ne...
remoting/host/host_main.cc:237: if (!args.empty()) {
On 2013/08/13 23:33:38, Sergey Ulanov wrote:
> I think you fixed this in a separate CL.

Yup, had to merge it here for testing while it was in the queue.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
File remoting/host/setup/host_starter.cc (right):

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:105: if (host_id_.empty()) {
On 2013/08/13 23:33:38, Sergey Ulanov wrote:
> Add a comment that this function is used for both user account and robot
> account.
> 
> Maybe check that host_owner_ is not empty here instead of looking at host_id_,
> just to make this more readable?

Done.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:107: xmpp_login_ = user_email;
On 2013/08/13 23:33:38, Sergey Ulanov wrote:
> I think it's better to set host_owner_ here and copy it to xmpp_login_ if we
> don't get auth code for the robot account.

Done.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:137: } else {
On 2013/08/13 23:33:38, Sergey Ulanov wrote:
> add return in the case above and remove else. The no-robot-account case above
> will be removed eventually.

Done.

https://codereview.chromium.org/22992002/diff/1/remoting/host/setup/host_star...
remoting/host/setup/host_starter.cc:156: if (!host_owner_.empty()) {
On 2013/08/13 23:33:38, Sergey Ulanov wrote:
> Can we always set host_owner, even when using user credentials for the host
(in
> that case host_owner = xmpp_login)?

https://codereview.chromium.org/19796006/ uses the absence of a host_owner to
mean it's an old (non-service-account) host config. If I always write it here,
there will be two special cases to check on remoting_me2me_host - no host_owner
(old configs), and host_owner == xmpp_login (we can't just follow the
service_account codepath in that case, because it uses different api keys for
xmpp_login).

[Sergey Ulanov, 2013-08-15 22:28:32]

LGTM
please add BUG= to point to 224742

[commit-bot: I haz the power, 2013-08-16 18:23:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/22992002/7001

[commit-bot: I haz the power, 2013-08-16 22:29:55]

Change committed as 218106