Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2299193003: Turn off incremental wrapper tracing by default (Closed)

Created:
4 years, 3 months ago by Marcel Hlopko
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn off incremental wrapper tracing by default With the flag on the blink tests fail because blink is not prepared for v8 behaving incrementally. In order to land and enable incremental wrapper tracing both in v8 smoothly and blink we need to: 1. Land ScriptWrappableVisitorTest (http://crrev.com/2301213003) 2. Land write barriers implementation with more tests 3. Land write barriers installations 4. Enable incremental wrapper tracing on v8 side 5. Canary the heck out of this :) This way the tests should be passing and chrome shouldn't crash at any given moment. LOG=no BUG=468240 NOTRY=true Committed: https://crrev.com/883e0e70369210b5af17ce86e8de3e0ce8119911 Cr-Commit-Position: refs/heads/master@{#39132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Marcel Hlopko
4 years, 3 months ago (2016-09-02 11:46:34 UTC) #2
Michael Lippautz
lgtm
4 years, 3 months ago (2016-09-02 11:48:34 UTC) #3
Marcel Hlopko
4 years, 3 months ago (2016-09-02 11:49:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299193003/1
4 years, 3 months ago (2016-09-02 12:03:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 12:06:09 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 12:06:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/883e0e70369210b5af17ce86e8de3e0ce8119911
Cr-Commit-Position: refs/heads/master@{#39132}

Powered by Google App Engine
This is Rietveld 408576698