Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2299193002: 🚀 Reland of Add dex info and static initializers to resource_sizes.py (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Add dex info and static initializers to resource_sizes.py Last attempt: https://codereview.chromium.org/2302903002/ Reason for reland: Now works with crazy.libfoo.so The goal is to have a single script that reports all .apk size related metrics. * Uses method_count.py to get dex info. * Already had static initializer logic, but now shows it even without --so_with_symbols_path. * Tweaks the static initializer count logic to sum up rather for all .so files rather than report the same metric repeatedly. TBR=rnephew@chromium.org,amineer@chromium.org BUG=609365 Committed: https://crrev.com/ef2220f642057c2b4642bf99283347d1210c86ba Cr-Commit-Position: refs/heads/master@{#416005}

Patch Set 1 #

Patch Set 2 : Strip crazy. from filename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -22 lines) Patch
M build/android/method_count.py View 1 5 chunks +8 lines, -8 lines 0 comments Download
M build/android/resource_sizes.py View 1 6 chunks +58 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
agrieve
Created Reland of 🚀 Add dex info and static initializers to resource_sizes.py
4 years, 3 months ago (2016-09-01 15:34:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299193002/60001
4 years, 3 months ago (2016-09-01 18:37:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-09-01 18:42:51 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 18:47:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef2220f642057c2b4642bf99283347d1210c86ba
Cr-Commit-Position: refs/heads/master@{#416005}

Powered by Google App Engine
This is Rietveld 408576698