Revert of content: Fix Context creation logic in ContextProviderFactoryImpl.

Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=643199

The following tests (and probably others) became flaky in the past 24 hours or so:

BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
DownloadContentTest.ResumeRestoredDownload_ShortFile
DownloadContentTest.ResumeRestoredDownload_EtagMismatch
DragDownloadFileTest.DragDownloadFileTest_Complete
DragDownloadFileTest.DragDownloadFileTest_NetError
TracingControllerTest.NotWhitelistedMetadataStripped
UtilityProcessMojoClientBrowserTest.CallService
UtilityProcessMojoClientBrowserTest.ConnectionError
UtilityProcessHostImplBrowserTest.LaunchProcess

The common issue seems to be this DCHECK:
[FATAL:context_provider_factory_impl_android.cc(181)] Check failed: !in_shutdown_. The factory is shutting down, can't handle new requests

Original issue's description:
> content: Fix Context creation logic in ContextProviderFactoryImpl.
>
> 1) The BrowserGpuChannelHostFactory runs any pending callbacks during
> shutdown. This can become re-entrant if the caller queued more requests
> on getting a null GpuChannel. So destroy the ContextProviderFactoryImpl
> before destroying the BrowserGpuChannelHostFactory.
>
> 2) Specify the reason for the context creation failure in the callback
> from ContextProviderFactoryImpl so the callers can respond accordingly
> and retry if necessary.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/becb5a6cf904faee4024a13e9760b71245e77b31
> Cr-Commit-Position: refs/heads/master@{#415877}

TBR=sievers@chromium.org,piman@chromium.org,dtrainor@chromium.org,khushalsagar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/258820db7532d4c411c2000c0907c6cb35399c03
Cr-Commit-Position: refs/heads/master@{#415958}

[Michael van Ouwerkerk, 2016-09-01 15:19:16]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-09-01 15:19:17]

Created Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl.

[commit-bot: I haz the power, 2016-09-01 15:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 15:20:53]

Description was changed from

==========
Revert of content: Fix Context creation logic in ContextProviderFactoryImpl.
(patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=643199

The following tests (and probably others) became flaky in the past 24 hours or
so:

BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
DownloadContentTest.ResumeRestoredDownload_ShortFile
DownloadContentTest.ResumeRestoredDownload_EtagMismatch
DragDownloadFileTest.DragDownloadFileTest_Complete
DragDownloadFileTest.DragDownloadFileTest_NetError
TracingControllerTest.NotWhitelistedMetadataStripped
UtilityProcessMojoClientBrowserTest.CallService
UtilityProcessMojoClientBrowserTest.ConnectionError
UtilityProcessHostImplBrowserTest.LaunchProcess


The common issue seems to be this DCHECK:
[FATAL:context_provider_factory_impl_android.cc(181)] Check failed:
!in_shutdown_. The factory is shutting down, can't handle new requests

Original issue's description:
> content: Fix Context creation logic in ContextProviderFactoryImpl.
> 
> 1) The BrowserGpuChannelHostFactory runs any pending callbacks during
> shutdown. This can become re-entrant if the caller queued more requests
> on getting a null GpuChannel. So destroy the ContextProviderFactoryImpl
> before destroying the BrowserGpuChannelHostFactory.
> 
> 2) Specify the reason for the context creation failure in the callback
> from ContextProviderFactoryImpl so the callers can respond accordingly
> and retry if necessary.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/becb5a6cf904faee4024a13e9760b71245e77b31
> Cr-Commit-Position: refs/heads/master@{#415877}

TBR=sievers@chromium.org,piman@chromium.org,dtrainor@chromium.org,khushalsaga...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of content: Fix Context creation logic in ContextProviderFactoryImpl.
(patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=643199

The following tests (and probably others) became flaky in the past 24 hours or
so:

BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
DownloadContentTest.ResumeRestoredDownload_ShortFile
DownloadContentTest.ResumeRestoredDownload_EtagMismatch
DragDownloadFileTest.DragDownloadFileTest_Complete
DragDownloadFileTest.DragDownloadFileTest_NetError
TracingControllerTest.NotWhitelistedMetadataStripped
UtilityProcessMojoClientBrowserTest.CallService
UtilityProcessMojoClientBrowserTest.ConnectionError
UtilityProcessHostImplBrowserTest.LaunchProcess


The common issue seems to be this DCHECK:
[FATAL:context_provider_factory_impl_android.cc(181)] Check failed:
!in_shutdown_. The factory is shutting down, can't handle new requests

Original issue's description:
> content: Fix Context creation logic in ContextProviderFactoryImpl.
> 
> 1) The BrowserGpuChannelHostFactory runs any pending callbacks during
> shutdown. This can become re-entrant if the caller queued more requests
> on getting a null GpuChannel. So destroy the ContextProviderFactoryImpl
> before destroying the BrowserGpuChannelHostFactory.
> 
> 2) Specify the reason for the context creation failure in the callback
> from ContextProviderFactoryImpl so the callers can respond accordingly
> and retry if necessary.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/becb5a6cf904faee4024a13e9760b71245e77b31
> Cr-Commit-Position: refs/heads/master@{#415877}

TBR=sievers@chromium.org,piman@chromium.org,dtrainor@chromium.org,khushalsaga...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-01 15:20:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-01 15:23:25]

Description was changed from

==========
Revert of content: Fix Context creation logic in ContextProviderFactoryImpl.
(patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=643199

The following tests (and probably others) became flaky in the past 24 hours or
so:

BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
DownloadContentTest.ResumeRestoredDownload_ShortFile
DownloadContentTest.ResumeRestoredDownload_EtagMismatch
DragDownloadFileTest.DragDownloadFileTest_Complete
DragDownloadFileTest.DragDownloadFileTest_NetError
TracingControllerTest.NotWhitelistedMetadataStripped
UtilityProcessMojoClientBrowserTest.CallService
UtilityProcessMojoClientBrowserTest.ConnectionError
UtilityProcessHostImplBrowserTest.LaunchProcess


The common issue seems to be this DCHECK:
[FATAL:context_provider_factory_impl_android.cc(181)] Check failed:
!in_shutdown_. The factory is shutting down, can't handle new requests

Original issue's description:
> content: Fix Context creation logic in ContextProviderFactoryImpl.
> 
> 1) The BrowserGpuChannelHostFactory runs any pending callbacks during
> shutdown. This can become re-entrant if the caller queued more requests
> on getting a null GpuChannel. So destroy the ContextProviderFactoryImpl
> before destroying the BrowserGpuChannelHostFactory.
> 
> 2) Specify the reason for the context creation failure in the callback
> from ContextProviderFactoryImpl so the callers can respond accordingly
> and retry if necessary.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/becb5a6cf904faee4024a13e9760b71245e77b31
> Cr-Commit-Position: refs/heads/master@{#415877}

TBR=sievers@chromium.org,piman@chromium.org,dtrainor@chromium.org,khushalsaga...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of content: Fix Context creation logic in ContextProviderFactoryImpl.
(patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=643199

The following tests (and probably others) became flaky in the past 24 hours or
so:

BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
DownloadContentTest.ResumeRestoredDownload_ShortFile
DownloadContentTest.ResumeRestoredDownload_EtagMismatch
DragDownloadFileTest.DragDownloadFileTest_Complete
DragDownloadFileTest.DragDownloadFileTest_NetError
TracingControllerTest.NotWhitelistedMetadataStripped
UtilityProcessMojoClientBrowserTest.CallService
UtilityProcessMojoClientBrowserTest.ConnectionError
UtilityProcessHostImplBrowserTest.LaunchProcess

The common issue seems to be this DCHECK:
[FATAL:context_provider_factory_impl_android.cc(181)] Check failed:
!in_shutdown_. The factory is shutting down, can't handle new requests

Original issue's description:
> content: Fix Context creation logic in ContextProviderFactoryImpl.
>
> 1) The BrowserGpuChannelHostFactory runs any pending callbacks during
> shutdown. This can become re-entrant if the caller queued more requests
> on getting a null GpuChannel. So destroy the ContextProviderFactoryImpl
> before destroying the BrowserGpuChannelHostFactory.
>
> 2) Specify the reason for the context creation failure in the callback
> from ContextProviderFactoryImpl so the callers can respond accordingly
> and retry if necessary.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/becb5a6cf904faee4024a13e9760b71245e77b31
> Cr-Commit-Position: refs/heads/master@{#415877}

TBR=sievers@chromium.org,piman@chromium.org,dtrainor@chromium.org,khushalsaga...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/258820db7532d4c411c2000c0907c6cb35399c03
Cr-Commit-Position: refs/heads/master@{#415958}
==========

[commit-bot: I haz the power, 2016-09-01 15:23:26]

Patchset 1 (id:??) landed as
https://crrev.com/258820db7532d4c411c2000c0907c6cb35399c03
Cr-Commit-Position: refs/heads/master@{#415958}