chromeos: Remove dbus::FileDescriptor from LorgnetteManagerClient

chromeos: Remove dbus::FileDescriptor from LorgnetteManagerClient

ScanImageToFile does not need to be public. Merge it into
ScanImageToString.

BUG=621841
Committed: https://crrev.com/1b8cc27882d756b720f0101ff273930963e26ad5
Cr-Commit-Position: refs/heads/master@{#416201}

[hashimoto, 2016-09-01 09:22:24]

hashimoto@chromium.org changed reviewers:
+ satorux@chromium.org, stevenjb@chromium.org

[hashimoto, 2016-09-01 09:22:39]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 09:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 10:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 10:13:57]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-09-01 15:51:43]

lgtm w/ nit

https://codereview.chromium.org/2299143002/diff/1/chromeos/dbus/lorgnette_man...
File chromeos/dbus/lorgnette_manager_client.cc (right):

https://codereview.chromium.org/2299143002/diff/1/chromeos/dbus/lorgnette_man...
chromeos/dbus/lorgnette_manager_client.cc:29: typedef base::Callback<void(bool
succeeded)> ScanImageToFileCallback;
nit: This name is confusing now, maybe ScanToStringCallback ?

[satorux1, 2016-09-02 05:22:47]

lgtm with a nit

https://codereview.chromium.org/2299143002/diff/20001/chromeos/dbus/lorgnette...
File chromeos/dbus/lorgnette_manager_client.cc (right):

https://codereview.chromium.org/2299143002/diff/20001/chromeos/dbus/lorgnette...
chromeos/dbus/lorgnette_manager_client.cc:105: // ScanImageToFile invocation.
ScanImageToFile no longer exists? please update the comment.

[hashimoto, 2016-09-02 05:25:51]

https://codereview.chromium.org/2299143002/diff/1/chromeos/dbus/lorgnette_man...
File chromeos/dbus/lorgnette_manager_client.cc (right):

https://codereview.chromium.org/2299143002/diff/1/chromeos/dbus/lorgnette_man...
chromeos/dbus/lorgnette_manager_client.cc:29: typedef base::Callback<void(bool
succeeded)> ScanImageToFileCallback;
On 2016/09/01 15:51:43, stevenjb wrote:
> nit: This name is confusing now, maybe ScanToStringCallback ?
Moved this callback to ScanToStringCompletion class and renamed it to
CompletionCallback.
ScanToStringCallback can also be a bit confusing as we already have
ScanImageToStringCallback.

https://codereview.chromium.org/2299143002/diff/20001/chromeos/dbus/lorgnette...
File chromeos/dbus/lorgnette_manager_client.cc (right):

https://codereview.chromium.org/2299143002/diff/20001/chromeos/dbus/lorgnette...
chromeos/dbus/lorgnette_manager_client.cc:105: // ScanImageToFile invocation.
On 2016/09/02 05:22:46, satorux1 wrote:
> ScanImageToFile no longer exists? please update the comment.

Removed that part from the comment.

[hashimoto, 2016-09-02 05:25:57]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 05:26:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 05:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 05:30:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hashimoto, 2016-09-02 05:58:09]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2016-09-02 05:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, satorux@chromium.org
Link to the patchset: https://codereview.chromium.org/2299143002/#ps40001
(title: "Update comment")

[commit-bot: I haz the power, 2016-09-02 05:58:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 06:37:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 06:39:11]

Description was changed from

==========
chromeos: Remove dbus::FileDescriptor from LorgnetteManagerClient

ScanImageToFile does not need to be public. Merge it into
ScanImageToString.

BUG=621841
==========

to

==========
chromeos: Remove dbus::FileDescriptor from LorgnetteManagerClient

ScanImageToFile does not need to be public. Merge it into
ScanImageToString.

BUG=621841

Committed: https://crrev.com/1b8cc27882d756b720f0101ff273930963e26ad5
Cr-Commit-Position: refs/heads/master@{#416201}
==========

[commit-bot: I haz the power, 2016-09-02 06:39:12]

Patchset 3 (id:??) landed as
https://crrev.com/1b8cc27882d756b720f0101ff273930963e26ad5
Cr-Commit-Position: refs/heads/master@{#416201}