Chromium Code Reviews
DescriptionRevert of Fix loading accessibility tree for child frame that's already loaded. (patchset #1 id:1 of https://codereview.chromium.org/2299673002/ )
Reason for revert:
The added tests are failing on Mac. https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/7967
Original issue's description:
> Fix loading accessibility tree for child frame that's already loaded.
>
> Code leftover from the pre-OOPIF days was causing us to exit early from
> the RenderAccessibilityImpl constructor for some child frames that were
> already loaded. Everything worked fine if accessibility was already enabled
> when loading the frame, but if the frame was already loaded and then
> accessibility was enabled, this could cause it to fail to create an
> accessibility tree.
>
> The code in RenderAccessibilityImpl is no longer needed because now we
> have exactly one accessibility tree per frame.
>
> This wasn't caught by tests because we didn't cover both scenarios, we
> always enabled accessibility first.
>
> Added two variants of existing tests that load the page first and then
> enable accessibility.
>
> BUG=640231
>
> Committed: https://crrev.com/08139c18be3cbc6199636ae63783574dd317bafd
> Cr-Commit-Position: refs/heads/master@{#415733}
TBR=dtseng@chromium.org,dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640231
Committed: https://crrev.com/015e6c8aa7b0af34021c8ea7454a9e0318695d47
Cr-Commit-Position: refs/heads/master@{#415851}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||