Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2299113002: Revert of Fix loading accessibility tree for child frame that's already loaded. (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni, David Tseng
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix loading accessibility tree for child frame that's already loaded. (patchset #1 id:1 of https://codereview.chromium.org/2299673002/ ) Reason for revert: The added tests are failing on Mac. https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/7967 Original issue's description: > Fix loading accessibility tree for child frame that's already loaded. > > Code leftover from the pre-OOPIF days was causing us to exit early from > the RenderAccessibilityImpl constructor for some child frames that were > already loaded. Everything worked fine if accessibility was already enabled > when loading the frame, but if the frame was already loaded and then > accessibility was enabled, this could cause it to fail to create an > accessibility tree. > > The code in RenderAccessibilityImpl is no longer needed because now we > have exactly one accessibility tree per frame. > > This wasn't caught by tests because we didn't cover both scenarios, we > always enabled accessibility first. > > Added two variants of existing tests that load the page first and then > enable accessibility. > > BUG=640231 > > Committed: https://crrev.com/08139c18be3cbc6199636ae63783574dd317bafd > Cr-Commit-Position: refs/heads/master@{#415733} TBR=dtseng@chromium.org,dmazzoni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640231 Committed: https://crrev.com/015e6c8aa7b0af34021c8ea7454a9e0318695d47 Cr-Commit-Position: refs/heads/master@{#415851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -39 lines) Patch
M content/browser/accessibility/dump_accessibility_browsertest_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 2 chunks +8 lines, -23 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/accessibility/render_accessibility_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yhirano
Created Revert of Fix loading accessibility tree for child frame that's already loaded.
4 years, 3 months ago (2016-09-01 02:22:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299113002/1
4 years, 3 months ago (2016-09-01 02:23:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 02:23:56 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 02:26:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/015e6c8aa7b0af34021c8ea7454a9e0318695d47
Cr-Commit-Position: refs/heads/master@{#415851}

Powered by Google App Engine
This is Rietveld 408576698