X87: Remove CONST_LEGACY VariableMode.

X87: Remove CONST_LEGACY VariableMode.

  port 7516fe1eaa7910015d7732a1aa34e45e3e37586c (r39052)

  original commit message:
  The only remaining use of this VariableMode is for the names of sloppy
  named function expressions. This patch instead uses CONST for such
  bindings (just as we do in strict mode) and instead marks those
  Variables specially. During code generation a new helper method,
  Variable::throw_on_const_assignment(), is called to decide whether
  to throw or silently ignore the assignment.

BUG=

Committed: https://crrev.com/1722786cd37574ef57114e57887499feb8945651
Cr-Commit-Position: refs/heads/master@{#39059}

[zhengxing.li, 2016-09-01 02:20:55]

zhengxing.li@intel.com changed reviewers:
+ adamk@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[zhengxing.li, 2016-09-01 02:20:56]

PTAL, thanks!

[Weiliang, 2016-09-01 02:25:22]

lgtm

[zhengxing.li, 2016-09-01 02:25:58]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-09-01 02:26:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 02:49:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-01 02:49:52]

Description was changed from

==========
X87: Remove CONST_LEGACY VariableMode.

  port 7516fe1eaa7910015d7732a1aa34e45e3e37586c (r39052)

  original commit message:
  The only remaining use of this VariableMode is for the names of sloppy
  named function expressions. This patch instead uses CONST for such
  bindings (just as we do in strict mode) and instead marks those
  Variables specially. During code generation a new helper method,
  Variable::throw_on_const_assignment(), is called to decide whether
  to throw or silently ignore the assignment.

BUG=
==========

to

==========
X87: Remove CONST_LEGACY VariableMode.

  port 7516fe1eaa7910015d7732a1aa34e45e3e37586c (r39052)

  original commit message:
  The only remaining use of this VariableMode is for the names of sloppy
  named function expressions. This patch instead uses CONST for such
  bindings (just as we do in strict mode) and instead marks those
  Variables specially. During code generation a new helper method,
  Variable::throw_on_const_assignment(), is called to decide whether
  to throw or silently ignore the assignment.

BUG=

Committed: https://crrev.com/1722786cd37574ef57114e57887499feb8945651
Cr-Commit-Position: refs/heads/master@{#39059}
==========

[commit-bot: I haz the power, 2016-09-01 02:49:53]

Patchset 1 (id:??) landed as
https://crrev.com/1722786cd37574ef57114e57887499feb8945651
Cr-Commit-Position: refs/heads/master@{#39059}