Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2299043002: PPC/s390: Remove CONST_LEGACY VariableMode (Closed)

Created:
4 years, 3 months ago by JaideepBajwa
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Remove CONST_LEGACY VariableMode Port 7516fe1eaa7910015d7732a1aa34e45e3e37586c Original commit message: The only remaining use of this VariableMode is for the names of sloppy named function expressions. This patch instead uses CONST for such bindings (just as we do in strict mode) and instead marks those Variables specially. During code generation a new helper method, Variable::throw_on_const_assignment(), is called to decide whether to throw or silently ignore the assignment. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/3b40d4f2e5508644143ceda92e3da35273e8933e Cr-Commit-Position: refs/heads/master@{#39060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 3 months ago (2016-08-31 23:26:37 UTC) #1
john.yan
lgtm
4 years, 3 months ago (2016-09-01 00:25:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299043002/1
4 years, 3 months ago (2016-09-01 02:44:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 03:06:21 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 03:07:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b40d4f2e5508644143ceda92e3da35273e8933e
Cr-Commit-Position: refs/heads/master@{#39060}

Powered by Google App Engine
This is Rietveld 408576698