Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2299033005: Pass the old and new owner documents to the adoptedCallback. (Closed)

Created:
4 years, 3 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 3 months ago
Reviewers:
tkent, haraken, kojii
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass the old and new owner documents to the adoptedCallback. The DOM adopt node steps [1] say to pass the old and new owner documents to the adoptedCallback. [1] https://dom.spec.whatwg.org/#concept-node-adopt BUG=643048 Committed: https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a Cr-Commit-Position: refs/heads/master@{#416461}

Patch Set 1 #

Total comments: 1

Patch Set 2 : WTF_ARRAY_LENGTH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/adopt-node.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 1 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementAdoptedCallbackReaction.h View 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementAdoptedCallbackReaction.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp View 4 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 3 months ago (2016-09-02 06:07:54 UTC) #2
kojii
lgtm
4 years, 3 months ago (2016-09-02 06:14:08 UTC) #3
tkent
lgtm
4 years, 3 months ago (2016-09-02 06:42:02 UTC) #7
haraken
bindings/ LGTM https://codereview.chromium.org/2299033005/diff/1/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp (right): https://codereview.chromium.org/2299033005/diff/1/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp#newcode371 third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:371: runCallback(m_adoptedCallback.newLocal(isolate), element, argc, argv); argc => WTF_ARRAY_LENGTH(argv)
4 years, 3 months ago (2016-09-02 08:57:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299033005/20001
4 years, 3 months ago (2016-09-03 23:46:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-04 01:05:35 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 01:07:47 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a
Cr-Commit-Position: refs/heads/master@{#416461}

Powered by Google App Engine
This is Rietveld 408576698