Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 229903003: Fix Android keyboard showing detection (Closed)

Created:
6 years, 8 months ago by David Trainor- moved to gerrit
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Android keyboard showing detection Use the root view's height vs. the visible display frame instead of the screen height. This is because the window might not be the full size of the screen. BUG=251343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/android/java/src/org/chromium/ui/UiUtils.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
David Trainor- moved to gerrit
ptal thanks!
6 years, 8 months ago (2014-04-09 01:13:50 UTC) #1
Miguel Garcia
lgtm
6 years, 8 months ago (2014-04-09 08:51:52 UTC) #2
Ted C
lgtm
6 years, 8 months ago (2014-04-09 17:56:38 UTC) #3
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 8 months ago (2014-04-10 00:30:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/229903003/1
6 years, 8 months ago (2014-04-10 00:31:33 UTC) #5
commit-bot: I haz the power
Change committed as 262913
6 years, 8 months ago (2014-04-10 04:50:10 UTC) #6
عواد الحويطي
6 years, 8 months ago (2014-04-13 07:27:18 UTC) #7
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698