Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2299023003: Activate comboboxes (i.e. open dropdown menu) on Enter and Space. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Activate comboboxes (i.e. open dropdown menu) on Enter and Space. Note that pressing space while the menu is open does nothing. This matches html <select> behavior. Pressing Enter while the menu is open selects the highlighted option and closes the menu. This also matches <select>. BUG=616685 Committed: https://crrev.com/6f4a390626d934c6473e3023788968b87f8186d9 Cr-Commit-Position: refs/heads/master@{#416051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M ui/views/controls/combobox/combobox.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ui/views/controls/combobox/combobox_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
4 years, 3 months ago (2016-09-01 01:30:31 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-01 18:20:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299023003/1
4 years, 3 months ago (2016-09-01 19:58:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 20:57:11 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:00:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f4a390626d934c6473e3023788968b87f8186d9
Cr-Commit-Position: refs/heads/master@{#416051}

Powered by Google App Engine
This is Rietveld 408576698