Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc

Issue 2299013003: Disable flaky AutofillPrivateApiTest tests (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/common/extensions/api/autofill_private.h" 9 #include "chrome/common/extensions/api/autofill_private.h"
10 #include "components/keyed_service/core/keyed_service.h" 10 #include "components/keyed_service/core/keyed_service.h"
(...skipping 30 matching lines...) Expand all
41 }; 41 };
42 42
43 } // namespace 43 } // namespace
44 44
45 // TODO(hcarmona): Investigate converting these tests to unittests. 45 // TODO(hcarmona): Investigate converting these tests to unittests.
46 46
47 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveAddress) { 47 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveAddress) {
48 EXPECT_TRUE(RunAutofillSubtest("saveAddress")) << message_; 48 EXPECT_TRUE(RunAutofillSubtest("saveAddress")) << message_;
49 } 49 }
50 50
51 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetCountryList) { 51 // TODO(crbug.com/643097) Disabled for flakiness.
52 #if defined(OS_WIN)
53 #define MAYBE_GetCountryList DISABLED_GetCountryList
54 #else
55 #define MAYBE_GetCountryList GetCountryList
56 #endif // defined(OS_WIN)
57 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_GetCountryList) {
52 EXPECT_TRUE(RunAutofillSubtest("getCountryList")) << message_; 58 EXPECT_TRUE(RunAutofillSubtest("getCountryList")) << message_;
53 } 59 }
54 60
55 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetAddressComponents) { 61 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetAddressComponents) {
56 EXPECT_TRUE(RunAutofillSubtest("getAddressComponents")) << message_; 62 EXPECT_TRUE(RunAutofillSubtest("getAddressComponents")) << message_;
57 } 63 }
58 64
59 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveCreditCard) { 65 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveCreditCard) {
60 EXPECT_TRUE(RunAutofillSubtest("saveCreditCard")) << message_; 66 EXPECT_TRUE(RunAutofillSubtest("saveCreditCard")) << message_;
61 } 67 }
62 68
63 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, RemoveEntry) { 69 // TODO(crbug.com/643097) Disabled for flakiness.
70 #if defined(OS_WIN)
71 #define MAYBE_RemoveEntry DISABLED_RemoveEntry
72 #else
73 #define MAYBE_RemoveEntry RemoveEntry
74 #endif // defined(OS_WIN)
75 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_RemoveEntry) {
64 EXPECT_TRUE(RunAutofillSubtest("removeEntry")) << message_; 76 EXPECT_TRUE(RunAutofillSubtest("removeEntry")) << message_;
65 } 77 }
66 78
67 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, ValidatePhoneNumbers) { 79 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, ValidatePhoneNumbers) {
68 EXPECT_TRUE(RunAutofillSubtest("ValidatePhoneNumbers")) << message_; 80 EXPECT_TRUE(RunAutofillSubtest("ValidatePhoneNumbers")) << message_;
69 } 81 }
70 82
71 } // namespace extensions 83 } // namespace extensions
72 84
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698