Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 2299003002: Remove uses of external begin frame sources (Closed)
Patch Set: Fix test crashes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index b548f9d2bcdb33fee5bbb03bae13c62ae2c948ac..470354e255ee02bea4734d2f0669bfde0f70f8ad 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -241,13 +241,8 @@ void RenderWidgetCompositor::Initialize(float device_scale_factor) {
params.task_graph_runner = compositor_deps_->GetTaskGraphRunner();
params.main_task_runner =
compositor_deps_->GetCompositorMainThreadTaskRunner();
- if (settings.use_external_begin_frame_source) {
- params.external_begin_frame_source =
- delegate_->CreateExternalBeginFrameSource();
- } else {
- DCHECK(settings.use_output_surface_begin_frame_source);
- }
params.animation_host = cc::AnimationHost::CreateMainInstance();
+ DCHECK(settings.use_output_surface_begin_frame_source);
if (cmd->HasSwitch(switches::kUseRemoteCompositing)) {
DCHECK(!threaded_);
@@ -475,15 +470,6 @@ cc::LayerTreeSettings RenderWidgetCompositor::GenerateLayerTreeSettings(
if (cmd.HasSwitch(switches::kDisableLowResTiling))
settings.create_low_res_tiling = false;
- // TODO(enne): fold external BFS into output surface BFS.
- if (cmd.HasSwitch(switches::kUseRemoteCompositing)) {
- settings.use_output_surface_begin_frame_source = true;
- settings.use_external_begin_frame_source = false;
- } else {
- settings.use_output_surface_begin_frame_source = false;
- settings.use_external_begin_frame_source = true;
- }
-
if (cmd.HasSwitch(switches::kEnableRGBA4444Textures) &&
!cmd.HasSwitch(switches::kDisableRGBA4444Textures)) {
settings.renderer_settings.preferred_tile_format = cc::RGBA_4444;

Powered by Google App Engine
This is Rietveld 408576698