Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: src/apinatives.js

Issue 22990003: Add RemovePrototype to FunctionTemplate (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Test that function throws when constructed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/macros.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 var cache = kApiFunctionCache; 68 var cache = kApiFunctionCache;
69 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset); 69 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
70 var isFunctionCached = 70 var isFunctionCached =
71 (serialNumber in cache) && (cache[serialNumber] != kUninitialized); 71 (serialNumber in cache) && (cache[serialNumber] != kUninitialized);
72 if (!isFunctionCached) { 72 if (!isFunctionCached) {
73 try { 73 try {
74 cache[serialNumber] = null; 74 cache[serialNumber] = null;
75 var fun = %CreateApiFunction(data); 75 var fun = %CreateApiFunction(data);
76 if (name) %FunctionSetName(fun, name); 76 if (name) %FunctionSetName(fun, name);
77 cache[serialNumber] = fun; 77 cache[serialNumber] = fun;
78 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
79 var flags = %GetTemplateField(data, kApiFlagOffset); 78 var flags = %GetTemplateField(data, kApiFlagOffset);
80 // Note: Do not directly use an object template as a condition, our 79 if (flags & (1 << kRemovePrototypeBit)) {
81 // internal ToBoolean doesn't handle that! 80 %FunctionRemovePrototype(fun);
82 fun.prototype = typeof prototype === 'undefined' ? 81 } else {
83 {} : Instantiate(prototype); 82 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
84 if (flags & (1 << kReadOnlyPrototypeBit)) { 83 // Note: Do not directly use an object template as a condition, our
85 %FunctionSetReadOnlyPrototype(fun); 84 // internal ToBoolean doesn't handle that!
86 } 85 fun.prototype = typeof prototype === 'undefined' ?
87 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM); 86 {} : Instantiate(prototype);
88 var parent = %GetTemplateField(data, kApiParentTemplateOffset); 87 if (flags & (1 << kReadOnlyPrototypeBit)) {
89 // Note: Do not directly use a function template as a condition, our 88 %FunctionSetReadOnlyPrototype(fun);
90 // internal ToBoolean doesn't handle that! 89 }
91 if (!(typeof parent === 'undefined')) { 90 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
92 var parent_fun = Instantiate(parent); 91 var parent = %GetTemplateField(data, kApiParentTemplateOffset);
93 %SetPrototype(fun.prototype, parent_fun.prototype); 92 // Note: Do not directly use a function template as a condition, our
93 // internal ToBoolean doesn't handle that!
94 if (!(typeof parent === 'undefined')) {
95 var parent_fun = Instantiate(parent);
96 %SetPrototype(fun.prototype, parent_fun.prototype);
97 }
94 } 98 }
95 ConfigureTemplateInstance(fun, data); 99 ConfigureTemplateInstance(fun, data);
96 } catch (e) { 100 } catch (e) {
97 cache[serialNumber] = kUninitialized; 101 cache[serialNumber] = kUninitialized;
98 throw e; 102 throw e;
99 } 103 }
100 } 104 }
101 return cache[serialNumber]; 105 return cache[serialNumber];
102 } 106 }
103 107
104 108
105 function ConfigureTemplateInstance(obj, data) { 109 function ConfigureTemplateInstance(obj, data) {
106 var properties = %GetTemplateField(data, kApiPropertyListOffset); 110 var properties = %GetTemplateField(data, kApiPropertyListOffset);
107 if (properties) { 111 if (properties) {
108 // Disable access checks while instantiating the object. 112 // Disable access checks while instantiating the object.
109 var requires_access_checks = %DisableAccessChecks(obj); 113 var requires_access_checks = %DisableAccessChecks(obj);
110 try { 114 try {
111 for (var i = 0; i < properties[0]; i += 3) { 115 for (var i = 0; i < properties[0]; i += 3) {
112 var name = properties[i + 1]; 116 var name = properties[i + 1];
113 var prop_data = properties[i + 2]; 117 var prop_data = properties[i + 2];
114 var attributes = properties[i + 3]; 118 var attributes = properties[i + 3];
115 var value = Instantiate(prop_data, name); 119 var value = Instantiate(prop_data, name);
116 %SetProperty(obj, name, value, attributes); 120 %SetProperty(obj, name, value, attributes);
117 } 121 }
118 } finally { 122 } finally {
119 if (requires_access_checks) %EnableAccessChecks(obj); 123 if (requires_access_checks) %EnableAccessChecks(obj);
120 } 124 }
121 } 125 }
122 } 126 }
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698