Add RemovePrototype to FunctionTemplate

Add RemovePrototype to FunctionTemplate

This allows functions created from a FunctionTemplate to not have a
prototype property, which is required by DOM methods.

R=mstarzinger@chromium.org
BUG=chromium:272440
Committed: http://code.google.com/p/v8/source/detail?r=16341

[arv (Not doing code reviews), 2013-08-13 23:11:12]

Hi Dan,

I'm not sure who is the best person to review FunctionTemplate changes. If there
is someone else that is more suitable feel free to change the reviewers.

Thanks

[dcarney, 2013-08-14 19:39:31]

On 2013/08/13 23:11:12, arv wrote:
> Hi Dan,
> 
> I'm not sure who is the best person to review FunctionTemplate changes. If
there
> is someone else that is more suitable feel free to change the reviewers.
> 
> Thanks

It seems somewhat unnatural to not have a prototype property, but, whatever the
spec wants...  The implementation seems reasonable to me, but I've added
mstarzinger as a reviewer since he and I have been looking at functiontemplate a
lot lately.

[arv (Not doing code reviews), 2013-08-14 20:26:38]

On 2013/08/14 19:39:31, dcarney wrote:
> On 2013/08/13 23:11:12, arv wrote:
> > Hi Dan,
> > 
> > I'm not sure who is the best person to review FunctionTemplate changes. If
> there
> > is someone else that is more suitable feel free to change the reviewers.
> > 
> > Thanks
> 
> It seems somewhat unnatural to not have a prototype property, but, whatever
the
> spec wants...  The implementation seems reasonable to me, but I've added
> mstarzinger as a reviewer since he and I have been looking at functiontemplate
a
> lot lately.

I agree that it strange not to have a prototype property but these functions are
similar to the JS built-in ones, like Date.prototype.getTime, which all lack the
prototype property.

[Michael Starzinger, 2013-08-15 08:49:24]

LGTM if one comment if addressed.

https://codereview.chromium.org/22990003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/22990003/diff/1/test/cctest/test-api.cc#newco...
test/cctest/test-api.cc:9532: CHECK(!CompileRun("'prototype' in
fun")->BooleanValue());
Can we add an additional check that "fun" actually throws when being called as a
constructor? I was thinking along the lines of the following two checks ...

  v8::TryCatch try_catch;
  CompileRun("new fun");
  CHECK(try_catch.HasCaught());

  try_catch.Reset();
  fun->NewInstance();
  CHECK(try_catch.HasCaught());

[arv (Not doing code reviews), 2013-08-15 13:18:35]

Thanks Michael,

I've expended the test to ensure that the function throws when constructed.

Do you mind committing this for me when you have the time?

[Michael Starzinger, 2013-08-16 07:41:00]

Yes, I will land this as soon as our tree is open again.

[arv (Not doing code reviews), 2013-08-26 16:43:47]

On 2013/08/16 07:41:00, Michael Starzinger wrote:
> Yes, I will land this as soon as our tree is open again.

I see that the tree has been opened.

[Michael Starzinger, 2013-08-26 17:40:15]

Committed patchset #2 manually as r16341 (presubmit successful).