Issue 22990002: Adding TLS support to the TCP Client sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22990002: Adding TLS support to the TCP Client sockets. (Closed)

Created:
7 years, 4 months ago by Mallinath (Gone from Chromium)

Modified:
7 years, 4 months ago

Reviewers:
Sergey Ulanov, vrk (LEFT CHROMIUM), jln (very slow on Chromium), juberti2

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Clone of @ https://codereview.chromium.org/22452002/ which is LGTMed by @sergeyu and @juberti. Adding TLS support to the TCP Client sockets. In case of WebRTC TLS socket will be created when application passes TURNS url. TurnPort will request for creating TLS sockets. In other instances TLS will be done using Pseudo-TLS, i.e. when TCPPort creates ssltcp, it's actually a pseudo-tls. TBR=vrk@chromium.org,jln@chromium.org,sergeyu@chromium.org,juberti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217145

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -14 lines)			Patch
M	content/browser/renderer_host/p2p/socket_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp.cc	View	7 chunks	+90 lines, -12 lines	0 comments	Download
M	content/common/p2p_sockets.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/media/media_stream_dependency_factory.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/p2p/ipc_socket_factory.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	content/renderer/p2p/port_allocator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/p2p/port_allocator.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Mallinath (Gone from Chromium)

7 years, 4 months ago (2013-08-13 00:58:34 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r217145.