Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Issue 2298973002: Use dependency_overrides / analyzer in analysis_server. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use dependency_overrides / analyzer in analysis_server. RFC We always do this locally, but until analysis_server is published, we could just keep this change in repo. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/72f5463631e4813190fb5f0b443fe8eee8373abc

Patch Set 1 #

Patch Set 2 : Also use dependency_overrides / analyzer in analyzer_cli. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/pubspec.yaml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-08-31 21:07:56 UTC) #1
Brian Wilkerson
lgtm. Should we do the same thing with analyzer_cli?
4 years, 3 months ago (2016-08-31 21:30:48 UTC) #2
Paul Berry
I have a vague memory that we tried to do this once in the past ...
4 years, 3 months ago (2016-08-31 21:43:10 UTC) #3
scheglov
4 years, 3 months ago (2016-08-31 21:44:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72f5463631e4813190fb5f0b443fe8eee8373abc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698