Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2298953003: Handle XI_Enter and XI_Leave events. (Closed)

Created:
4 years, 3 months ago by kylechar
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org, wjmaclean, Tom Anderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle XI_Enter and XI_Leave events. These events are now expected and are hitting a NOTREACHED statement. Add case to handle them but doesn't do anything to avoid this. BUG=642856 Committed: https://crrev.com/a6e7a8cb6df5a0ab7ddc7fe38e279e98ae0bd548 Cr-Commit-Position: refs/heads/master@{#416714}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ui/events/x/events_x_utils.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kylechar
4 years, 3 months ago (2016-09-01 18:10:07 UTC) #2
sadrul
https://codereview.chromium.org/2298953003/diff/1/ui/events/x/events_x_utils.cc File ui/events/x/events_x_utils.cc (right): https://codereview.chromium.org/2298953003/diff/1/ui/events/x/events_x_utils.cc#newcode275 ui/events/x/events_x_utils.cc:275: // We don't handle enter/leave but they're expected. We ...
4 years, 3 months ago (2016-09-01 23:12:55 UTC) #3
kylechar
https://codereview.chromium.org/2298953003/diff/1/ui/events/x/events_x_utils.cc File ui/events/x/events_x_utils.cc (right): https://codereview.chromium.org/2298953003/diff/1/ui/events/x/events_x_utils.cc#newcode275 ui/events/x/events_x_utils.cc:275: // We don't handle enter/leave but they're expected. On ...
4 years, 3 months ago (2016-09-06 17:29:57 UTC) #4
sadrul
lgtm
4 years, 3 months ago (2016-09-06 19:29:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298953003/20001
4 years, 3 months ago (2016-09-06 19:30:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 20:41:51 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:43:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6e7a8cb6df5a0ab7ddc7fe38e279e98ae0bd548
Cr-Commit-Position: refs/heads/master@{#416714}

Powered by Google App Engine
This is Rietveld 408576698