Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2298943004: Fix bad origin check. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -37 lines) Patch
M runtime/bin/vmservice/server.dart View 1 2 3 6 chunks +24 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmacnak
4 years, 3 months ago (2016-09-09 00:03:29 UTC) #3
Cutch
lgtm
4 years, 3 months ago (2016-09-09 00:08:57 UTC) #4
Cutch
On 2016/09/09 00:08:57, Cutch wrote: > lgtm wait, we need to discuss this in person.
4 years, 3 months ago (2016-09-09 13:50:30 UTC) #5
rmacnak
Checking specifically for localhost when allowing cross origin requests. PTAL.
4 years, 3 months ago (2016-09-09 20:40:14 UTC) #6
Cutch
lgtm
4 years, 3 months ago (2016-09-09 21:44:58 UTC) #7
rmacnak
4 years, 3 months ago (2016-09-09 23:34:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
fcda790b9c237011a54e01da09e460d78f524c00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698