Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2298943002: Roll buildtools adb8bf4e8f..82d2a28e42 (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools adb8bf4e8f..82d2a28e42 In order to roll GN 2eb03fab2b..fe79dde87a (r411754:r415725) and pick up the following changes: 8fcde24 Re-write many calls to WrapUnique() with MakeUnique() 38182d4 Use shell=False on non-Windows for gn-format.py 9e92b9d gn: Reduce stack memory use while parsing. 6d8fdaa Implement `gn analyze`. c3b4559 gn: Don't read unitialized memory on files containing just a comment. 5aba5ce gn: Don't do an out-of-bound access if a file ends after 'else' 11772ab gn: Mention loadable_module targets in the cookbook. 45b76ee Fix GN bootstrap e47a4763 Add a fuzzer for gn's parser. 9f58d6d gn: make gn gen preserve import statements passed in --args c4e3e52 gn: Use a separate flag for enabling libgnome-keyring support. e9fcf20 GN: fail gracefully when git commit info cannot be extracted b68d6d7 Remove GN back-compat toolchain args code. TBR=brettw@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
4 years, 3 months ago (2016-08-31 20:06:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298943002/1
4 years, 3 months ago (2016-08-31 20:06:26 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/272414)
4 years, 3 months ago (2016-08-31 20:42:47 UTC) #5
Dirk Pranke
4 years, 3 months ago (2016-09-12 19:21:47 UTC) #7
Message was sent while issue was closed.
Abandoning ... will roll in a newer version.

Powered by Google App Engine
This is Rietveld 408576698