Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2298933003: [IntersectionObserver] Enable observations across shadow DOM roots. (Closed)

Created:
4 years, 3 months ago by szager1
Modified:
4 years, 3 months ago
Reviewers:
eae, ojan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[IntersectionObserver] Enable observations across shadow DOM roots. BUG=638434 R=ojan@chromium.org,eae@chromium.org Committed: https://crrev.com/257e833d93e4f9c7ed1cad01bcae892e6db79cde Cr-Commit-Position: refs/heads/master@{#415839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/intersection-observer/shadow-content.html View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/intersection-observer/shadow-content-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
szager1
4 years, 3 months ago (2016-08-31 22:11:20 UTC) #1
eae
LGTM
4 years, 3 months ago (2016-08-31 22:49:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298933003/1
4 years, 3 months ago (2016-08-31 22:50:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 01:42:32 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 01:45:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/257e833d93e4f9c7ed1cad01bcae892e6db79cde
Cr-Commit-Position: refs/heads/master@{#415839}

Powered by Google App Engine
This is Rietveld 408576698