Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 229893004: Revert of roll skia DEPS to 14128 (Closed)

Created:
6 years, 8 months ago by benchen
Modified:
6 years, 8 months ago
CC:
chromium-reviews, skia-team_google.com
Visibility:
Public.

Description

Revert of roll skia DEPS to 14128 (https://codereview.chromium.org/232783004/) Reason for revert: breaking Chrome bots http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio Original issue's description: > roll skia DEPS to 14128 > > Chromium base revision: 262955 / > Old Skia revision: 14102 > New Skia revision: 14128 > Control CL: https://codereview.chromium.org/233193002/ > > Bypassing commit queue trybots: > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263093 TBR=reed@google.com,bsalomon@google.com,robertphillips@google.com,mtklein@google.com,rmistry@google.com,djsollen@google.com NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benchen
Created Revert of roll skia DEPS to 14128
6 years, 8 months ago (2014-04-10 22:37:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bensong@google.com/229893004/1
6 years, 8 months ago (2014-04-10 22:37:47 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 22:37:48 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-10 22:37:49 UTC) #4
benchen
6 years, 8 months ago (2014-04-10 22:43:17 UTC) #5
Glad it didn't go through. brettw landed a fix so it'll probably stick.

Powered by Google App Engine
This is Rietveld 408576698