sandbox/linux/services/broker_process.h - Issue 229893002: Add unit test to check for broker FD leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/services/broker_process.h

Issue 229893002: Add unit test to check for broker FD leak (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add BrokerProcessTestHelper to avoid hard-coding macro-generated identifiers Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/services/broker_process.h

diff --git a/sandbox/linux/services/broker_process.h b/sandbox/linux/services/broker_process.h

index b312b8f67ddaa9e2bd061a39285920b2520e3470..6645deb4be71f0bdcf763d0fdb8b3d3a74a3cba1 100644

--- a/sandbox/linux/services/broker_process.h

+++ b/sandbox/linux/services/broker_process.h

@@ -97,6 +97,8 @@ class SANDBOX_EXPORT BrokerProcess {

const std::vector<std::string> allowed_w_files_; // Files allowed for write.

int ipc_socketpair_; // Our communication channel to parent or child.

DISALLOW_IMPLICIT_CONSTRUCTORS(BrokerProcess);

+ friend class BrokerProcessTestHelper;

};

} // namespace sandbox