Disallow non-namespaced use of base::Version.

Disallow non-namespaced use of base::Version.

This is a reland of
https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0
which is a reland of
https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910

BUG=639416
Committed: https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab
Cr-Commit-Position: refs/heads/master@{#415991}

[pwnall, 2016-09-01 16:30:47]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 16:30:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-09-01 16:49:07]

pwnall@chromium.org changed reviewers:
+ thakis@chromium.org

[pwnall, 2016-09-01 16:49:07]

PTAL? Hoping the 3rd time's a charm :D

[Nico, 2016-09-01 16:57:22]

lgtm

The usual practice for relanding reverts is to upload the patch-as-it-was as
patch set 1 and the modified version as patch set 2 so that it's easy to see
what changed btw. (In this case it's easy even without you doing that, but still
a good habit to have)

[pwnall, 2016-09-01 17:03:55]

On 2016/09/01 16:57:22, Nico wrote:
> lgtm
> 
> The usual practice for relanding reverts is to upload the patch-as-it-was as
> patch set 1 and the modified version as patch set 2 so that it's easy to see
> what changed btw. (In this case it's easy even without you doing that, but
still
> a good habit to have)

Thank you for the quick turnaround and for teaching me about relands! I will do
2 patch sets from now on!

[commit-bot: I haz the power, 2016-09-01 17:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:29:21]

Dry run: This issue passed the CQ dry run.

[pwnall, 2016-09-01 17:44:37]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 17:48:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-01 17:50:36]

Description was changed from

==========
Disallow non-namespaced use of base::Version.

This is a reland of
https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0
which is a reland of
https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910

BUG=639416
==========

to

==========
Disallow non-namespaced use of base::Version.

This is a reland of
https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0
which is a reland of
https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910

BUG=639416

Committed: https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab
Cr-Commit-Position: refs/heads/master@{#415991}
==========

[commit-bot: I haz the power, 2016-09-01 17:50:37]

Patchset 1 (id:??) landed as
https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab
Cr-Commit-Position: refs/heads/master@{#415991}

[fgorski, 2016-09-01 19:37:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2301183002/ by fgorski@chromium.org.

The reason for reverting is: 
Build broken again:

https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chr....