Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2298923003: Disallow non-namespaced use of base::Version. (Closed)

Created:
4 years, 3 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow non-namespaced use of base::Version. This is a reland of https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0 which is a reland of https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 BUG=639416 Committed: https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab Cr-Commit-Position: refs/heads/master@{#415991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M base/version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/obsolete_system/obsolete_system_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
pwnall
PTAL? Hoping the 3rd time's a charm :D
4 years, 3 months ago (2016-09-01 16:49:07 UTC) #4
Nico
lgtm The usual practice for relanding reverts is to upload the patch-as-it-was as patch set ...
4 years, 3 months ago (2016-09-01 16:57:22 UTC) #5
pwnall
On 2016/09/01 16:57:22, Nico wrote: > lgtm > > The usual practice for relanding reverts ...
4 years, 3 months ago (2016-09-01 17:03:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298923003/1
4 years, 3 months ago (2016-09-01 17:44:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 17:48:59 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab Cr-Commit-Position: refs/heads/master@{#415991}
4 years, 3 months ago (2016-09-01 17:50:37 UTC) #13
fgorski
4 years, 3 months ago (2016-09-01 19:37:09 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2301183002/ by fgorski@chromium.org.

The reason for reverting is: 
Build broken again:

https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chr....

Powered by Google App Engine
This is Rietveld 408576698