Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2298913002: Garcefully handle glCreateGpuMemoryBufferImageCHROMIUM failure. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Garcefully handle glCreateGpuMemoryBufferImageCHROMIUM failure. Creates a black frame instead of CHECKing if gl context is lost or glCreateGpuMemoryBufferImageCHROMIUM fails. The default platform for ozone (headless), used for content_browsertests on cast bots, does not support Pixmaps. BUG=641559 Committed: https://crrev.com/33e6e6b45312ce953f9c4c2521b12705c1fe0fba Cr-Commit-Position: refs/heads/master@{#415865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M media/renderers/video_overlay_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/renderers/video_overlay_factory.cc View 3 chunks +50 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alokp
4 years, 3 months ago (2016-08-31 18:42:12 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 3 months ago (2016-08-31 23:27:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298913002/1
4 years, 3 months ago (2016-08-31 23:29:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 02:54:24 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 02:58:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33e6e6b45312ce953f9c4c2521b12705c1fe0fba
Cr-Commit-Position: refs/heads/master@{#415865}

Powered by Google App Engine
This is Rietveld 408576698