Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2298893002: Roll recipe dependencies (MANUAL). (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll recipe dependencies (MANUAL). Additions: * Remove PYTHONUNBUFFERED for svn tests This obviates https://codereview.chromium.org/2298863002/. recipe_engine: https://crrev.com/09345f9dcf4d2744f66d64766fd349ddf04f04ce Cancel PYTHONUNBUFFERED when unbuffered is explicitly set to False (iannucci@chromium.org) TBR=martiniss@chromium.org, phajdan.jr@chromium.org BUG=635641 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3458f046e0b77a71422c5664c6a00be17845c5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
M tests/test-lib.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298893002/1
4 years, 3 months ago (2016-08-31 18:33:03 UTC) #3
martiniss
lgtm
4 years, 3 months ago (2016-08-31 18:34:29 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:40:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3458f046e0b77...

Powered by Google App Engine
This is Rietveld 408576698