Fix code order in CBC_QRCoderEncoder::InterleaveWithECBytes

Move maxNumDataBytes and maxNumEcBytes calculation to fix crash

The blocks.Add will std::move the unique_ptrs, so the std::max calculations
need to go before. Without this change, pdfium_test will crash when trying
to render test/barcode_test.pdf with XFA enabled.
Tested that after this change, barcode_test.pdf is rendered without crashing.

Committed: https://pdfium.googlesource.com/pdfium/+/fc9b11358a47e1dd9b257263c9457d7e53b9dd10

[npm, 2016-08-31 17:14:06]

Description was changed from

==========
Fix code order in CBC_QRCoderEncoder::InterleaveWithECBytes
==========

to

==========
Move maxNumDataBytes and maxNumEcBytes calculation to fix crash

The blocks.Add will std::move the unique_ptrs, so the std::max calculations
need to go before. Without this change, pdfium_test will crash when trying
to render test/barcode_test.pdf with XFA enabled.
Tested that after this change, barcode_test.pdf is rendered without crashing.
==========

[npm, 2016-08-31 17:14:06]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, weili@chromium.org

[npm, 2016-08-31 17:14:37]

PTAL

[dsinclair, 2016-08-31 17:42:01]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-31 17:42:01]

lgtm

[commit-bot: I haz the power, 2016-08-31 17:42:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-08-31 17:49:29]

lgtm

[commit-bot: I haz the power, 2016-08-31 17:51:22]

Description was changed from

==========
Move maxNumDataBytes and maxNumEcBytes calculation to fix crash

The blocks.Add will std::move the unique_ptrs, so the std::max calculations
need to go before. Without this change, pdfium_test will crash when trying
to render test/barcode_test.pdf with XFA enabled.
Tested that after this change, barcode_test.pdf is rendered without crashing.
==========

to

==========
Move maxNumDataBytes and maxNumEcBytes calculation to fix crash

The blocks.Add will std::move the unique_ptrs, so the std::max calculations
need to go before. Without this change, pdfium_test will crash when trying
to render test/barcode_test.pdf with XFA enabled.
Tested that after this change, barcode_test.pdf is rendered without crashing.

Committed:
https://pdfium.googlesource.com/pdfium/+/fc9b11358a47e1dd9b257263c9457d7e53b9...
==========

[commit-bot: I haz the power, 2016-08-31 17:51:23]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fc9b11358a47e1dd9b257263c9457d7e53b9...