Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams

net/http/http_stream_parser.h

Index: net/http/http_stream_parser.h
diff --git a/net/http/http_stream_parser.h b/net/http/http_stream_parser.h
index a70af6560fd0b283397c7916d2fc44236ba0926e..64600ab8b0ec2f6addb0a8b043d06036e9a885b4 100644
--- a/net/http/http_stream_parser.h
+++ b/net/http/http_stream_parser.h
@@ -196,12 +196,20 @@ class NET_EXPORT_PRIVATE HttpStreamParser {
   // Check if buffers used to send the request are empty.
   bool SendRequestBuffersEmpty();
 
+  // Sets request_ to null.
+  void ResetRequestInfo();
+
   // Next state of the request, when the current one completes.
   State io_state_;
 
-  // The request to send.
+  // Null when read state machine is invoked. This is to allow the stream
+  // to be shared for reading and to possibly outlive request_'s owner
+  // URLRequestHttpJob.
   const HttpRequestInfo* request_;

[Randy Smith (Not in Mondays), 2016/09/01 20:18:31]

Though (i.e. not even to the level of suggestion): Would it be cleaner to make
all of these references weak pointers, so we don't have to rely on the
ResetRequestInfo() being correctly plumbed to cleanup references to to-be-freed
memory?  We can still have documentation in the constructors/methods from which
the various classes get this pointer as to how long the owner must keep the
pointer alive for, but with a weak pointer we'll get a clean crash when the
plumbing fails as opposed to a use-after-free bug.

 
+  // upload progress saved while resetting the request info to null.
+  UploadProgress upload_progress_;
+
   // The request header data.  May include a merged request body.
   scoped_refptr<DrainableIOBuffer> request_headers_;