Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: net/http/http_transaction.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased till refs/heads/master@{#425377} Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_parser.cc ('k') | net/quic/chromium/quic_http_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_transaction.h
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index b39e6514426149783d292b5766db5c320a7740ff..eff45d10c5648d618e4366a6ea91a398b06016b1 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -52,6 +52,10 @@ class NET_EXPORT_PRIVATE HttpTransaction {
// Starts the HTTP transaction (i.e., sends the HTTP request).
//
+ // The consumer should ensure that request_info points to a valid value till
+ // final response headers are received; after that point, the HttpTransaction
+ // will not access |*request_info| and it may be deleted.
+ //
// Returns OK if the transaction could be started synchronously, which means
// that the request was served from the cache. ERR_IO_PENDING is returned to
// indicate that the CompletionCallback will be notified once response info is
« no previous file with comments | « net/http/http_stream_parser.cc ('k') | net/quic/chromium/quic_http_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698