Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: net/http/http_stream.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased till refs/heads/master@{#425377} Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/http/http_stream_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream.h
diff --git a/net/http/http_stream.h b/net/http/http_stream.h
index b161a8702f29299757207233b7c2fe431a34e909..3def66ee9a2dfc2d8d9fd14a4a100d85c8b09f6e 100644
--- a/net/http/http_stream.h
+++ b/net/http/http_stream.h
@@ -47,7 +47,9 @@ class NET_EXPORT_PRIVATE HttpStream {
virtual ~HttpStream() {}
// Initialize stream. Must be called before calling SendRequest().
- // |request_info| must outlive the HttpStream.
+ // The consumer should ensure that request_info points to a valid value till
+ // final response headers are received; after that point, the HttpStream
+ // will not access |*request_info| and it may be deleted.
// Returns a net error code, possibly ERR_IO_PENDING.
virtual int InitializeStream(const HttpRequestInfo* request_info,
RequestPriority priority,
« no previous file with comments | « net/http/http_network_transaction.cc ('k') | net/http/http_stream_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698