net/url_request/url_request_ftp_job.h - Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)

Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_ftp_job.h

diff --git a/net/url_request/url_request_ftp_job.h b/net/url_request/url_request_ftp_job.h

index 35d6593a8d4ca33c92719f9536ac356f7fc59d4d..d48d82d2068f1d0de37a47b6205a12e6c4c475eb 100644

--- a/net/url_request/url_request_ftp_job.h

+++ b/net/url_request/url_request_ftp_job.h

@@ -70,8 +70,6 @@ class NET_EXPORT_PRIVATE URLRequestFtpJob : public URLRequestJob {

void SetAuth(const AuthCredentials& credentials) override;

void CancelAuth() override;

- // TODO(ibrar): Yet to give another look at this function.

- UploadProgress GetUploadProgress() const override;

int ReadRawData(IOBuffer* buf, int buf_size) override;

void HandleAuthNeededResponse();