Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: net/spdy/spdy_http_stream_unittest.cc

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_http_stream_unittest.cc
diff --git a/net/spdy/spdy_http_stream_unittest.cc b/net/spdy/spdy_http_stream_unittest.cc
index 1c5fb345cc2614dc2d5b424e37a030f5f07b48b8..96149e8050ef7c90cc046a1848a3388e6d2e50ab 100644
--- a/net/spdy/spdy_http_stream_unittest.cc
+++ b/net/spdy/spdy_http_stream_unittest.cc
@@ -168,24 +168,6 @@ class SpdyHttpStreamTest : public testing::Test {
MockECSignatureCreatorFactory ec_signature_creator_factory_;
};
-// SpdyHttpStream::GetUploadProgress() should still work even before the
-// stream is initialized.
-TEST_F(SpdyHttpStreamTest, GetUploadProgressBeforeInitialization) {
- MockRead reads[] = {
- MockRead(ASYNC, 0, 0) // EOF
- };
-
- InitSession(reads, arraysize(reads), nullptr, 0);
-
- SpdyHttpStream stream(session_, false);
- UploadProgress progress = stream.GetUploadProgress();
- EXPECT_EQ(0u, progress.size());
- EXPECT_EQ(0u, progress.position());
-
- // Pump the event loop so |reads| is consumed before the function returns.
- base::RunLoop().RunUntilIdle();
-}
-
TEST_F(SpdyHttpStreamTest, SendRequest) {
SpdySerializedFrame req(
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));

Powered by Google App Engine
This is Rietveld 408576698