Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: net/http/http_network_transaction.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction.h
diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h
index 87dc819ec619c8aa9faf3bde2428840429f1b021..535765da8f844d267292f2cb18df8696ef7bf28b 100644
--- a/net/http/http_network_transaction.h
+++ b/net/http/http_network_transaction.h
@@ -78,7 +78,6 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
void DoneReading() override;
const HttpResponseInfo* GetResponseInfo() const override;
LoadState GetLoadState() const override;
- UploadProgress GetUploadProgress() const override;
void SetQuicServerInfo(QuicServerInfo* quic_server_info) override;
bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;
bool GetRemoteEndpoint(IPEndPoint* endpoint) const override;
@@ -301,6 +300,9 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
void CopyConnectionAttemptsFromStreamRequest();
+ // Resets request_ to nullptr.
+ void ResetRequestInfo();
+
scoped_refptr<HttpAuthController>
auth_controllers_[HttpAuth::AUTH_NUM_TARGETS];
@@ -315,7 +317,12 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
HttpNetworkSession* session_;
BoundNetLog net_log_;
+
+ // Reset to null during the Read state machine.
Randy Smith (Not in Mondays) 2016/09/09 17:28:24 nit, suggestion: "... to null before the Read stat
shivanisha 2016/09/13 19:58:34 done.
const HttpRequestInfo* request_;
+
+ // The requested URL.
+ GURL url_;
RequestPriority priority_;
HttpResponseInfo response_;

Powered by Google App Engine
This is Rietveld 408576698