Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams

net/http/http_stream_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_PARSER_H_
 #define NET_HTTP_HTTP_STREAM_PARSER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 178 matching lines @@
 
   // Examine the parsed headers to try to determine the response body size.
   void CalculateResponseBodySize();
 
   // Uploads statistics about status line compliance with RFC 7230.
   void ValidateStatusLine(const std::string& status_line);
 
   // Check if buffers used to send the request are empty.
   bool SendRequestBuffersEmpty();
 
+  // Sets request_ to null.
+  void ResetRequestInfo();
+
   // Next state of the request, when the current one completes.
   State io_state_;
 
-  // The request to send.
+  // Null when read state machine is invoked. This is to allow the stream
+  // to be shared for reading and to possibly outlive request_'s owner
+  // URLRequestHttpJob.
   const HttpRequestInfo* request_;

[Randy Smith (Not in Mondays), 2016/09/01 20:18:31]

Though (i.e. not even to the level of suggestion): Would it be cleaner to make
all of these references weak pointers, so we don't have to rely on the
ResetRequestInfo() being correctly plumbed to cleanup references to to-be-freed
memory?  We can still have documentation in the constructors/methods from which
the various classes get this pointer as to how long the owner must keep the
pointer alive for, but with a weak pointer we'll get a clean crash when the
plumbing fails as opposed to a use-after-free bug.

 
+  // upload progress saved while resetting the request info to null.
+  UploadProgress upload_progress_;
+
   // The request header data.  May include a merged request body.
   scoped_refptr<DrainableIOBuffer> request_headers_;
 
   // Size of just the request headers.  May be less than the length of
   // |request_headers_| if the body was merged with the headers.
   int request_headers_length_;
 
   // Temporary buffer for reading.
   scoped_refptr<GrowableIOBuffer> read_buf_;
 
@@ skipping 66 matching lines @@
   int upload_error_;
 
   base::WeakPtrFactory<HttpStreamParser> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpStreamParser);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_PARSER_H_