Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams

net/http/http_basic_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A class that stores the common state between HttpBasicStream and
 // WebSocketBasicHandshakeStream.
 
 #ifndef NET_HTTP_HTTP_BASIC_STATE_H_
 #define NET_HTTP_HTTP_BASIC_STATE_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
+#include "url/gurl.h"
 
 namespace net {
 
 class BoundNetLog;
 class ClientSocketHandle;
 class GrowableIOBuffer;
 class HttpStreamParser;
 struct HttpRequestInfo;
 
 class NET_EXPORT_PRIVATE HttpBasicState {
@@ skipping 27 matching lines @@
 
  private:
   scoped_refptr<GrowableIOBuffer> read_buf_;
 
   std::unique_ptr<HttpStreamParser> parser_;
 
   std::unique_ptr<ClientSocketHandle> connection_;
 
   const bool using_proxy_;
 
-  const HttpRequestInfo* request_info_;
+  GURL url_;
+  std::string request_method_;

[mmenke, 2016/08/31 21:57:59]

Why do we need these?  Generating the request line after the HttpRequestInfo is
cleared is useless anyways - we no longer have the request body to upload.

[shivanisha, 2016/09/08 20:43:54]

We need these only for generating request line. I have saved these instead of
request info pointer as request info is not needed here leading to one less case
to worry about for resetting.

 
   DISALLOW_COPY_AND_ASSIGN(HttpBasicState);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_BASIC_STATE_H_