Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: net/url_request/url_request_http_job_unittest.cc

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <cstddef> 9 #include <cstddef>
10 #include <memory> 10 #include <memory>
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 ADD_FAILURE(); 774 ADD_FAILURE();
775 return ERR_NOT_IMPLEMENTED; 775 return ERR_NOT_IMPLEMENTED;
776 } 776 }
777 777
778 void Drain(HttpNetworkSession* session) override {} 778 void Drain(HttpNetworkSession* session) override {}
779 779
780 void PopulateNetErrorDetails(NetErrorDetails* details) override { return; } 780 void PopulateNetErrorDetails(NetErrorDetails* details) override { return; }
781 781
782 void SetPriority(RequestPriority priority) override {} 782 void SetPriority(RequestPriority priority) override {}
783 783
784 UploadProgress GetUploadProgress() const override {
785 return UploadProgress();
786 }
787
788 HttpStream* RenewStreamForAuth() override { return nullptr; } 784 HttpStream* RenewStreamForAuth() override { return nullptr; }
789 785
790 // Fake implementation of WebSocketHandshakeStreamBase method(s) 786 // Fake implementation of WebSocketHandshakeStreamBase method(s)
791 std::unique_ptr<WebSocketStream> Upgrade() override { 787 std::unique_ptr<WebSocketStream> Upgrade() override {
792 return std::unique_ptr<WebSocketStream>(); 788 return std::unique_ptr<WebSocketStream>();
793 } 789 }
794 790
795 private: 791 private:
796 bool initialize_stream_was_called_; 792 bool initialize_stream_was_called_;
797 }; 793 };
(...skipping 21 matching lines...) Expand all
819 base::RunLoop().RunUntilIdle(); 815 base::RunLoop().RunUntilIdle();
820 EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status()); 816 EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status());
821 EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called()); 817 EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called());
822 } 818 }
823 819
824 #endif // defined(ENABLE_WEBSOCKETS) 820 #endif // defined(ENABLE_WEBSOCKETS)
825 821
826 } // namespace 822 } // namespace
827 823
828 } // namespace net 824 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698