Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 2298803004: Fix for undefined reject() in extension_view_api_methods.js. (Closed)

Created:
4 years, 3 months ago by paulmeyer
Modified:
4 years, 3 months ago
Reviewers:
apacible
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for undefined reject() in extension_view_api_methods.js. It looks like reject() is defined in extension_view.js. Perhaps this code was pulled from there at some point. In any case, it seems that this should just be a call to this.pendingLoad.reject(). BUG=642849 Committed: https://crrev.com/b637f11d3d60568755148fa7d7a25c50d477b716 Cr-Commit-Position: refs/heads/master@{#415745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/renderer/resources/guest_view/extension_view/extension_view_api_methods.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
paulmeyer
+apacible@ for review.
4 years, 3 months ago (2016-08-31 19:34:11 UTC) #2
apacible
lgtm thanks!
4 years, 3 months ago (2016-08-31 19:49:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298803004/1
4 years, 3 months ago (2016-08-31 20:42:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:46:48 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:48:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b637f11d3d60568755148fa7d7a25c50d477b716
Cr-Commit-Position: refs/heads/master@{#415745}

Powered by Google App Engine
This is Rietveld 408576698